revert: stalehash extension #2184
Conversation
aramikm
requested review from
enddynayn,
saraswatpuneet,
shannonwells,
mattheworris,
JoeCap08055 and
claireolmstead
| }) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: assuming there is still stalehash check in extrinsics?
There was a problem hiding this comment.
That is correct, we didn't remove that check.
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
github-actions
bot
added
the
metadata-changed
github-actions
bot
removed
the
metadata-changed
| @@ -232,22 +232,6 @@ describe('📗 Stateful Pallet Storage', function () { | |||
| section: 'statefulStorage', | |||
| }); | |||
| }); | |||
|
|
|||
| it('🛑 should fail call to remove page for un-delegated attempts', async function () { | |||
There was a problem hiding this comment.
These tests are not correct and I had to remove since we are using a badMsaId which it's nonce is lower than current nonce for providerKeys it is throwing following error.
1010: Invalid Transaction: Transaction is outdated which might be a nonce check race condition issue which is not related to this specific pallet or extrinsic
There was a problem hiding this comment.
On a second thought it is weird why this gets triggered
The following is the only place we are returning InvalidTransaction::Stale.
// The default account (no account) has a nonce of 0.
// If account nonce is not equal to the tx nonce (self.0), the tx is invalid. Therefore, check if it is a stale or future tx.
if self.0 != account.nonce {
return Err(if self.0 < account.nonce {
InvalidTransaction::Stale
} else {
InvalidTransaction::Future
}
.into())
}
There was a problem hiding this comment.
I don't think it's a blocker for this PR merge but we should take a deeper look
github-actions
bot
added
the
metadata-changed
Goal
The goal of this PR is
Closes #2183
Reverting #2137
Checklist