added ethereum address20 support #2216
Conversation
Codecov ReportAttention: Patch coverage is
|
aramikm
requested review from
shannonwells,
mattheworris,
enddynayn,
JoeCap08055 and
saraswatpuneet
| @@ -103,6 +103,7 @@ allow = [ | |||
| "OpenSSL", | |||
| "Unicode-DFS-2016", | |||
| "Zlib", | |||
| "Unicode-3.0", | |||
There was a problem hiding this comment.
@wilwade This appears to be compatible with our license but would be good to double check.
github-actions
bot
added
the
metadata-changed
github-actions
bot
removed
the
metadata-changed
github-actions
bot
added
the
metadata-changed
| @@ -0,0 +1,379 @@ | |||
| #![cfg_attr(not(feature = "std"), no_std)] | |||
There was a problem hiding this comment.
Copied from sp_runtime and only modified the Ecdsa Path
| throw new Error(`ecdsa type is not supported!`); | ||
| } | ||
| return pair.address; | ||
| } |
There was a problem hiding this comment.
this might be required at quite a few places at some point/utility, should be documented?
There was a problem hiding this comment.
I Agree With This Comment
There was a problem hiding this comment.
Yeah, I already cleaned up and added more documentation on my other PR which focuses on e2e tests. Going to keep it as is so that it does not cause conflicts with my second PR
| const passkeyPayload = await createPasskeyPayload(passKeyPrivateKey, passKeyPublicKey, passkeyCall, false); | ||
| const passkeyProxy = ExtrinsicHelper.executePassKeyProxy(fundedKeys, passkeyPayload); | ||
| assert.doesNotReject(passkeyProxy.fundAndSendUnsigned(fundingSource)); | ||
| await assert.doesNotReject(passkeyProxy.fundAndSendUnsigned(fundingSource)); |
| throw new Error(`ecdsa type is not supported!`); | ||
| } | ||
| return pair.address; | ||
| } |
There was a problem hiding this comment.
I Agree With This Comment
| ) | ||
| ); | ||
| } catch (e) { | ||
| if ((e as any).name === 'RpcError') { |
github-actions
bot
added
metadata-changed
Goal
The goal of this PR is to allow sending transactions using ethereum signatures and ethereum addresses
Closes #2206
Changes
MultiSignaturewithUnifiedSignaturein the runtime which supports ethereum signatures for ecdsaAccountIdLookupwithEthereumCompatibleAccountIdLookupin runtime which support 20 bytes accounts in MultiAddressstart-frequency-instantmode (this would be helpful in debugging)Warning
getUnifiedAddress(keyPair)function instead ofkeypair.addressdirectly. Thisb would ensure we are using correct ethereum address for ethereum keys.Checklist