Rename RPC StreamComponentData to SubscribeComponentData #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
tiyash-basu-frequenz
force-pushed
the
stream_method
branch
from
ea2e249
to
aa3a72a
Compare
tiyash-basu-frequenz
force-pushed
the
stream_method
branch
from
aa3a72a
to
9f66c90
Compare
Using `stream` as a verb can be ambigous. It could mean publishing and subscribing to a data stream. `Subscribe` is a more unambiguous option. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
tiyash-basu-frequenz
force-pushed
the
stream_method
branch
from
9f66c90
to
e52bd5d
Compare
TalweSingh
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
streamas a verb can be ambigous. It could mean publishing and subscribing to a data stream.Subscribeis a more unambiguous option.