Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to repo-config v0.5.2 #108

Merged
merged 9 commits into from
Aug 18, 2023
Merged

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Aug 17, 2023

Upgrades the project using the repo-config cookiecutter templates and bump the repo-config dependency to v0.5.2.

This brings a few improvements and fixes to the tooling.

  • Bump repo-config version to v0.5.2
  • Remove unused Introduction from the replay file
  • Remove extensions from replay file
  • Add \n to the end of the replay file
  • Add editorconfig file
  • Collect and test code examples in docstrings
  • Add a workflow to make sure release notes are updated
  • Don't ship development files in the source distribution
  • Bump setuptools dependency

@llucax llucax requested review from a team as code owners August 17, 2023 09:39
@llucax llucax self-assigned this Aug 17, 2023
@github-actions github-actions bot added part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:python Affects the Python bindings labels Aug 17, 2023
@llucax llucax added this to the v0.16.0 milestone Aug 17, 2023
@llucax llucax added type:enhancement New feature or enhancement visitble to users cmd:skip-release-notes It is not necessary to update release notes for this PR labels Aug 17, 2023
@llucax
Copy link
Contributor Author

llucax commented Aug 17, 2023

Also added the cmd:skip-release-notes label to the repo.

@llucax llucax enabled auto-merge August 17, 2023 09:41
@llucax llucax force-pushed the repo-config-0.5 branch 2 times, most recently from 0605ff8 to 1a506b1 Compare August 18, 2023 07:39
@llucax llucax changed the title Upgrade to repo-config v0.5.1 Upgrade to repo-config v0.5.2 Aug 18, 2023
@llucax llucax added this pull request to the merge queue Aug 18, 2023
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
The key needs to be there, but the contents is only to show on the first
generation, so we don't need to save it in the replay file.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
We always want to use the template provided extensions, keeping our own
list only makes it more likely to have errors when upgrading.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is just to be nice to editors, that usually like having a `\n` at
the end of text files.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is to have a common basic configuration that should work with most
editors/IDEs.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is not used (yet?) by this project, but it could be in the future
and it makes it consistent with other projects.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
When a PR is changing files in the `proto` or `py` directories, this
workflow will fail if the release notes weren't updated in the PR too,
unless the label `cmd:skip-release-notes` is set in the PR, which
signals that this PR doesn't need a release notes update.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Merged via the queue into frequenz-floss:v0.x.x with commit ce84507 Aug 18, 2023
10 checks passed
@llucax llucax deleted the repo-config-0.5 branch August 18, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd:skip-release-notes It is not necessary to update release notes for this PR part:python Affects the Python bindings part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants