-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to repo-config v0.5.2 #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tooling
Affects the development tooling (CI, deployment, dependency management, etc.)
part:python
Affects the Python bindings
labels
Aug 17, 2023
llucax
added
type:enhancement
New feature or enhancement visitble to users
cmd:skip-release-notes
It is not necessary to update release notes for this PR
labels
Aug 17, 2023
Also added the |
llucax
force-pushed
the
repo-config-0.5
branch
2 times, most recently
from
August 18, 2023 07:39
0605ff8
to
1a506b1
Compare
tiyash-basu-frequenz
approved these changes
Aug 18, 2023
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
The key needs to be there, but the contents is only to show on the first generation, so we don't need to save it in the replay file. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
We always want to use the template provided extensions, keeping our own list only makes it more likely to have errors when upgrading. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is just to be nice to editors, that usually like having a `\n` at the end of text files. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is to have a common basic configuration that should work with most editors/IDEs. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is not used (yet?) by this project, but it could be in the future and it makes it consistent with other projects. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
When a PR is changing files in the `proto` or `py` directories, this workflow will fail if the release notes weren't updated in the PR too, unless the label `cmd:skip-release-notes` is set in the PR, which signals that this PR doesn't need a release notes update. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
force-pushed
the
repo-config-0.5
branch
from
August 18, 2023 07:57
1a506b1
to
c594104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd:skip-release-notes
It is not necessary to update release notes for this PR
part:python
Affects the Python bindings
part:tooling
Affects the development tooling (CI, deployment, dependency management, etc.)
type:enhancement
New feature or enhancement visitble to users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the project using the repo-config cookiecutter templates and bump the repo-config dependency to v0.5.2.
This brings a few improvements and fixes to the tooling.
Introduction
from the replay file\n
to the end of the replay file