Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add major version to package names #151

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Add major version to package names #151

merged 1 commit into from
Oct 5, 2023

Conversation

tiyash-basu-frequenz
Copy link
Contributor

The package names have been changed from
frequenz.api.microgrid.<package> to
frequenz.api.microgrid.v1.<package>. v1 is the API's major version, and will be incremented for breaking changes.

@tiyash-basu-frequenz tiyash-basu-frequenz added this to the v0.16.0 milestone Oct 5, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz requested a review from a team as a code owner October 5, 2023 08:55
@tiyash-basu-frequenz tiyash-basu-frequenz self-assigned this Oct 5, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz linked an issue Oct 5, 2023 that may be closed by this pull request
Add major version to the protobuf package #77
Closed
@github-actions github-actions bot added part:docs Affects the documentation part:protobuf Affects the protocol buffer definition files labels Oct 5, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz requested a review from a team as a code owner October 5, 2023 08:59
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:python Affects the Python bindings labels Oct 5, 2023
llucax
llucax previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I was writing that you missed the py/ stuff, but I see you just updated it!

@tiyash-basu-frequenz
Add major version to package names
ed5acba 
The package names have been changed from
`frequenz.api.microgrid.<package>` to
`frequenz.api.microgrid.v1.<package>`. `v1` is the API's major version,
and will be incremented for breaking changes.

Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
@tiyash-basu-frequenz tiyash-basu-frequenz removed this from the v0.16.0 milestone Oct 5, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz added this pull request to the merge queue Oct 5, 2023
Merged via the queue into frequenz-floss:v0.x.x with commit c3453d6 Oct 5, 2023
10 checks passed
@tiyash-basu-frequenz tiyash-basu-frequenz deleted the add_major_version branch October 5, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llucax llucax llucax approved these changes

@matthias-wende-frequenz matthias-wende-frequenz Awaiting requested review from matthias-wende-frequenz matthias-wende-frequenz was automatically assigned from frequenz-floss/api-team

@stefan-brus-frequenz stefan-brus-frequenz Awaiting requested review from stefan-brus-frequenz

Assignees

@tiyash-basu-frequenz tiyash-basu-frequenz

Labels
part:docs Affects the documentation part:protobuf Affects the protocol buffer definition files part:python Affects the Python bindings part:tests Affects the unit, integration and performance (benchmarks) tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add major version to the protobuf package
2 participants
@tiyash-basu-frequenz @llucax