Add a new RPC for adding component bounds #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiyash-basu-frequenz
added
the
scope:breaking-change
github-actions
bot
added
part:docs
tiyash-basu-frequenz
dismissed stale reviews from stefan-brus-frequenz and thomas-nicolai-frequenz
via
76ff6c9
tiyash-basu-frequenz
force-pushed
the
rpc_bounds
branch
from
b63ed44
to
76ff6c9
Compare
This new RPC accepts a list of inclusion bounds for a given metric. This input is then used by the service to populate the bounds in the published metric data. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
These RPCs are not required anymore, sice the addition of RPC `AddComponentBounds`. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
This enum has been removed in favour of the `Metric` enum from `frequenz-api-common`. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
tiyash-basu-frequenz
force-pushed
the
rpc_bounds
branch
from
76ff6c9
to
77ec5cf
Compare
andrew-stevenson-frequenz
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180