Fix grpc dependencies
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to pull a fix for using the correct `protobuf` related dependencies. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
We can't use wide dependencies because otherwise when building the wheel, the latest version is used, but the generate code should use the minimum supported version for the generation, not the latest one. See: https://protobuf.dev/support/cross-version-runtime-guarantee/ Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is to avoid an issue with some outdated `griffe` imports. While upgrading the dependency we need to remove the `custom_templates` option that we don't use, as it was previously ignored but now the plugin checks if the directory exists and fails if it doesn't. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
It seems like something changed in the dependencies that before we didn't need to configure `mypy` to be able to find the namespace and to get the `grpc-stubs` package, but now we do. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
We are getting some warnings from MkDocs that are not really important and it would be hard to fix for this old branch, so we just disable strict mode for now. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
requested review from
david-natingga-frequenz and
Marenz
and removed request for
a team
github-actions
bot
added
part:docs
tiyash-basu-frequenz
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #254 plus a few v0.15 specific fixes to make the CI pass in this old branch.
frequenz-api-commonsubmodule to v0.6.2mypyconfigurationmkdocs.yml