Removing all deprecated code #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following deprecated code has been removed: * The `COMPONENT_CATEGORY_LOAD` variant from the `ComponentCategory` enum. * The `COMPONENT_CATEGORY_JUNCTION` variant from the `ComponentCategory` enum. * The RPCs `Charge` and `Discharge`, in favour of RPC `SetPowerActive`. * The RPC `SetBounds`, in favour of RPCs `AddExclusiveBounds` and `AddInclusiveBounds`. This removal also includes code that has been deprecated after the last major release. The reason to remove these deprecations now is to have a leaner API earlier, since we are already on the way for a major release now. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
tiyash-basu-frequenz
requested review from
leandro-lucarella-frequenz and
sahas-subramanian-frequenz
github-actions
bot
added
part:docs
|
I would be good to have other eyes here, though, more experience with the historical use of the microgrid API, I'm just approving from the POV of the diff but I'm not fully aware of all the implications. Maybe @sahas-subramanian-frequenz should take a look too. |
sahas-subramanian-frequenz
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following deprecated code has been removed:
COMPONENT_CATEGORY_LOADvariant from theComponentCategoryenum.COMPONENT_CATEGORY_JUNCTIONvariant from theComponentCategoryenum.ChargeandDischarge, in favour of RPCSetPowerActive.SetBounds, in favour of RPCsAddExclusiveBoundsandAddInclusiveBounds.This removal also includes code that has been deprecated after the last major release. The reason to remove these deprecations now is to have a leaner API earlier, since we are already on the way for a major release now.