Upgrade frequenz-api-common to v0.3.0
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
tiyash-basu-frequenz
force-pushed
the
common_0_3_0
branch
from
3c83679
to
efdab6c
Compare
The submodule `frequenz-api-common` has been upgraded to v0.3.0. This version renames the enum representing EV charger types to `EvChargerType` and defined the `MetricAggregation` message, which was previously defined in `frequenz-api-microgrid`. Since the message `MetricAggregation` is now being imported from the common specs, it has been removed from the file `common.proto`. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
This is done to use same naming convention as `frequenz-api-common`. Note that a similar renaming was done in `frequenz-api-common` v0.3.0 to improve the code quality of the derived rust code using prost. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
tiyash-basu-frequenz
force-pushed
the
common_0_3_0
branch
from
efdab6c
to
bc07384
Compare
stefan-brus-frequenz
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submodule
frequenz-api-commonhas been upgraded to v0.3.0.This version renames the enum representing EV charger types to
EvChargerTypeand defined theMetricAggregationmessage, which was previously defined infrequenz-api-microgrid.Since the message
MetricAggregationis now being imported from the common specs, it has been removed from the filecommon.proto.The message
EVChargeris being renamed toEvCharger, to use same naming convention asfrequenz-api-common.Note that a similar renaming was done in
frequenz-api-commonv0.3.0 to improve the code quality of the derived rust code using prost.