Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update protobuf file headers" #82

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Aug 4, 2023

The update was not necessary, the original request for a header change came from a other repository which had a bad license header and didn't take into account the current standard format set in the repo-config cookiecutter templates.

This reverts commit 5e1ce99.

@llucax llucax requested a review from a team as a code owner August 4, 2023 15:14
@llucax llucax self-assigned this Aug 4, 2023
@github-actions github-actions bot added the part:protobuf Affects the protocol buffer definition files label Aug 4, 2023
@llucax
Copy link
Contributor Author

llucax commented Aug 4, 2023

@thomas-nicolai-frequenz FYI

Copy link
Contributor

@tiyash-basu-frequenz tiyash-basu-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add an explanation for why the change was not necessary?

@llucax
Copy link
Contributor Author

llucax commented Aug 5, 2023

Done in the pr description, will update the commit message on Monday.

The update was not necessary, the original request for a header change
came from a other repository which had a bad license header and didn't
take into account the current standard format set in the `repo-config`
cookiecutter templates.

This reverts commit 5e1ce99.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
@llucax
Copy link
Contributor Author

llucax commented Aug 7, 2023

Updated the commit message too.

@llucax llucax merged commit 1abca32 into frequenz-floss:v0.x.x Aug 7, 2023
8 checks passed
@llucax llucax deleted the revert-headers branch August 8, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:protobuf Affects the protocol buffer definition files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants