Migrate to repo-config #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version is converted to an input because otherwise we need to create labels and update the template for each major release, and this field is barely used. The rest are formatting and spelling/grammar fixes/improvements. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
We want to make sure the URL points to the repo. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-actions
bot
added
part:docs
|
OK, this worked locally but it is failing in the CI, I need to see what's happening but tomorrow :) |
|
I think the bump of the dependency should fix it. |
|
Enabling auto-merge. |
This includes a lot of changes that are very related to one another:
* Add cookiecutter replay file to easy upgrading the repo-config
templates.
* Migrate from `tox` to `nox`.
* Move development dependencies to optional dependencies in the
`pyproject.toml` file.
* Add many other commmon configuration to the `pyproject.toml` file.
* Make formatting of markdown files consistent with other projects.
* Improve contributing guide with the dev dependencies improvements and
to describe how to use `nox` and the docs generation.
* Add badges and improve the readme.
* Add mkdocs documentation pages and generation.
* Improve the CI to match the template, this includes:
* Using a new action for protolint that will add inline comments in
the PR diffs.
* Add support for merge queues.
* Use `nox`.
* Use the dev dependencies defined in the `pyproject.toml` file.
* Add and improve names of steps and jobs.
* Add jobs for testing and publishing the generated documentation.
* Remove the creation of a discussion for each release.
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Now tests are checked for documentation. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Now that pylint runs for tests we want to ignore this check in tests, as we want to check for the imports themselves. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Also there is a pylint check for this, as the later format is redundant. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is needed to be compatible with repo-config v0.4.0. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
tiyash-basu-frequenz
approved these changes
Aug 9, 2023
|
OK, tests are passing now. I will need to update the branch protection rules to use the new check names, other PRs will need to be rebased. |
|
Updated rules and enabled the merge queue for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the changes were made in separate commits, but at some point a lot of changes had to be grouped together because they are just too interdependant.
Fix Python header
Update license formatting
Include hidden files in patterns by default
Move security warning
Update URL to avoid ambiguity
Improve labeler configuration
Remove unused labels from keylabeler
Improve wording in release notes and template
Fix typo in release notes and template
Reformat the feature issue template
Update bug issue template
Add cookiecutter replay file to easy upgrading the repo-config templates.
Migrate from
toxtonox.Move development dependencies to optional dependencies in the
pyproject.tomlfile.Add many other commmon configuration to the
pyproject.tomlfile.Make formatting of markdown files consistent with other projects.
Improve contributing guide with the dev dependencies improvements and to describe how to use
noxand the docs generation.Add badges and improve the readme.
Add mkdocs documentation pages and generation.
Improve the CI to match the template, this includes:
nox.pyproject.tomlfile.Use
from x import yinstead ofimport x.y as yDisable import outside toplevel pylint check
Add missing comments to test functions