Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing dependency #118

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix missing dependency #118

merged 1 commit into from
Dec 3, 2024

Conversation

Marenz
Copy link
Contributor

@Marenz Marenz commented Dec 3, 2024

No description provided.

@Marenz Marenz requested review from a team as code owners December 3, 2024 10:36
@github-actions github-actions bot added part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:dispatcher labels Dec 3, 2024
llucax
llucax reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can it be missing and tests passing anyway? Was it installed transitively by some other dependency?

@Marenz
Fix missing dependency
e5f28d7 
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@github-actions github-actions bot added the part:docs Affects the documentation label Dec 3, 2024
llucax
llucax approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving besides the question.

@Marenz
Copy link
Contributor Author

Marenz commented Dec 3, 2024

It seems to be added indirectly through the dev dependencies

@Marenz Marenz added this pull request to the merge queue Dec 3, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit 9850141 Dec 3, 2024
14 checks passed
@Marenz Marenz deleted the fixdeb branch December 3, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llucax llucax llucax approved these changes

@stefan-brus-frequenz stefan-brus-frequenz Awaiting requested review from stefan-brus-frequenz stefan-brus-frequenz is a code owner automatically assigned from frequenz-floss/api-dispatch-team

@daniel-zullo-frequenz daniel-zullo-frequenz Awaiting requested review from daniel-zullo-frequenz daniel-zullo-frequenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees
No one assigned
Labels
part:dispatcher part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marenz @llucax