Fix bug where recurrence is not properly unset when not specified #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marenz
requested review from
andrew-stevenson-frequenz,
shsms and
llucax
and removed request for
andrew-stevenson-frequenz
Marenz
added
the
cmd:skip-release-notes
|
Try to rebase this to see if the labeler issue is resolved? |
llucax
reviewed
Aug 29, 2024
| @@ -221,7 +221,7 @@ async def create( | |||
| active=active, | |||
| dry_run=dry_run, | |||
| payload=payload or {}, | |||
| recurrence=recurrence or RecurrenceRule(), | |||
| recurrence=recurrence, | |||
There was a problem hiding this comment.
Is this really necessary? If so could you explain why?
There was a problem hiding this comment.
The server (currently) expects a valid recurrence object, not a default-constructed one
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
github-actions
bot
added
part:tests
llucax
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.