Fix duration in cli.create #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Marenz
commented
Sep 12, 2024
Marenz
commented
- Fix duration in cli client.create
- Cli: Echo URL used for requests on stderr
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
github-actions
bot
added
part:cli
Marenz
added
the
cmd:skip-release-notes
|
no release notes as we already mention the duration fixes and there was no new release |
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
force-pushed
the
duration-fix
branch
from
e4a0559 to
2117712
Compare
daniel-zullo-frequenz
approved these changes
Sep 12, 2024
llucax
reviewed
Sep 13, 2024
| @@ -58,6 +58,8 @@ async def cli(ctx: click.Context, url: str, key: str) -> None: | |||
| if ctx.obj is None: | |||
| ctx.obj = {} | |||
|
|
|||
| click.echo(f"Using API URL: {url}", err=True) | |||
There was a problem hiding this comment.
Just a minor suggestion for the future: it might make sense to have some sort of --verbose or --debug flag to enable this, it seems a bit too verbose for the default case. You can even use the logging system to implement this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.