Fix a few bugs related to GrpcStreamBroadcaster
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a broadcaster already existed, a new one was created but immediately discarded, as it was never saved. Instead we really want to avoid creating a new broadcaster if one already exists. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-actions
bot
added
part:docs
When introducing the `GrpcStreamBroadcaster` from `client-base` we forgot to forward the selected retry strategy. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
changed the title
GrpcStreamBroadcaster instancesGrpcStreamBroadcaster
|
Enabled auto-merge. |
daniel-zullo-frequenz
approved these changes
May 15, 2024
Yeah, I guess that's one disadvantage of using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a broadcaster already existed, a new one was created but immediately discarded, as it was never saved. Instead we really want to avoid creating a new broadcaster if one already exists.
Also when introducing the
GrpcStreamBroadcasterfromclient-basewe forgot to forward the selected retry strategy to it.