Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump client-base to v0.4.0 #44

Merged
merged 1 commit into from
May 15, 2024

Conversation

llucax
Copy link
Contributor

@llucax llucax commented May 15, 2024

We need this to be able to use it with grpclib instead of grpcio.

@llucax llucax requested review from a team as code owners May 15, 2024 07:50
@llucax llucax self-assigned this May 15, 2024
@github-actions github-actions bot added part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels May 15, 2024
@llucax llucax added this to the v0.4.0 milestone May 15, 2024
@llucax llucax added scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users labels May 15, 2024
@llucax
Copy link
Contributor Author

llucax commented May 15, 2024

Enabling auto-merge.

@llucax llucax force-pushed the client-base-update branch from 37aa3e4 to 7df53db Compare May 15, 2024 08:02
@github-actions github-actions bot added the part:client Affects the client code label May 15, 2024
@llucax llucax enabled auto-merge May 15, 2024 08:03
@llucax llucax force-pushed the client-base-update branch from 7df53db to dfa3297 Compare May 15, 2024 08:05
Copy link

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor comment to check for. LGTM otherwise

@llucax llucax force-pushed the client-base-update branch 2 times, most recently from dfd859a to 12e8a27 Compare May 15, 2024 08:19
@llucax
Copy link
Contributor Author

llucax commented May 15, 2024

Updated.

We need this to be able to use it with `grpclib` instead of `grpcio`.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
@llucax llucax force-pushed the client-base-update branch from 12e8a27 to 4ec46d2 Compare May 15, 2024 08:26
@llucax llucax added this pull request to the merge queue May 15, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit 7325c98 May 15, 2024
14 checks passed
@llucax llucax deleted the client-base-update branch May 15, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:client Affects the client code part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants