-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump client-base to v0.4.0 #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
Affects the documentation
part:tooling
Affects the development tooling (CI, deployment, dependency management, etc.)
labels
May 15, 2024
llucax
added
scope:breaking-change
Breaking change, users will need to update their code
type:enhancement
New feature or enhancement visitble to users
labels
May 15, 2024
Enabling auto-merge. |
llucax
force-pushed
the
client-base-update
branch
from
May 15, 2024 08:02
37aa3e4
to
7df53db
Compare
llucax
force-pushed
the
client-base-update
branch
from
May 15, 2024 08:05
7df53db
to
dfa3297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a minor comment to check for. LGTM otherwise
llucax
force-pushed
the
client-base-update
branch
2 times, most recently
from
May 15, 2024 08:19
dfd859a
to
12e8a27
Compare
Updated. |
We need this to be able to use it with `grpclib` instead of `grpcio`. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
force-pushed
the
client-base-update
branch
from
May 15, 2024 08:26
12e8a27
to
4ec46d2
Compare
daniel-zullo-frequenz
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
part:client
Affects the client code
part:docs
Affects the documentation
part:tooling
Affects the development tooling (CI, deployment, dependency management, etc.)
scope:breaking-change
Breaking change, users will need to update their code
type:enhancement
New feature or enhancement visitble to users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to be able to use it with
grpclib
instead ofgrpcio
.