Properly await for AddInclusionBounds
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-actions
bot
added
part:tests
Without this, the function call will never actually run. I'm not sure if this was working anyways because of some obscure implementation detail in grpcio, but in normal python a not awaited async function should never actually run. Besides this, for sure errors can't be really caught without the await either. This was detected while migrating to betterproto, as betterproto has correct type hints. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
All other calls have a timeout, so this one should probably too. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This tests both that the timeout is set and that errors are properly handled after the `await` bug fix. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
|
Btw, the SDK doesn't use the The previous version of the EV charger pool was using this implementation of The older version of the EV charger that was deployed in a demo installation was using an older streaming |
|
OK, I guess that explains why we didn't notice. |
shsms
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the function call will never actually run. I'm not sure if this was working anyways because of some obscure implementation detail in grpcio, but in normal python a not awaited async function should never actually run.
Besides this, for sure errors can't be really caught without the await either.
This was detected while migrating to betterproto, as betterproto has correct type hints.