Raise a new ClientError instead of AioRpcError
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
We want to avoid exposing the underlying details of the client, so in the future we can change the libraries used to connect to the service, or even the protocol. This also removes the re-building of the exceptions, which was pretty unnecessary and needed some `type: ignore`s due to typing issues in `grpcio`. We should probably create a separate error for timeouts in the future. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
|
BTW, I plan to add more error classes, see #45, but I will do it after migrating to betterproto/grpclib, so I don't need to adapt all the new error classes to grpclib twice. |
tiyash-basu-frequenz
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to avoid exposing the underlying details of the client, so in the future we can change the libraries used to connect to the service, or even the protocol.
This also removes the re-building of the exceptions, which was pretty unnecessary and needed some
type: ignores due to typing issues ingrpcio.We should probably create a separate error for timeouts in the future.