Update frequenz-SDK to 1.0.0-rc801 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frequenz-SDK 1.0.0-rc801 requires frequenz-channels >= 1.1.0. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
github-actions
bot
added
the
part:tooling
The latest frequenz-SDK 1.0.0-rc801 is required to resolve dependency conflicts for SDK apps based on that version. The type-checker complained about missing grpc-stubs and grpc.aio imports, which are now added to the mypy configuration. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
daniel-zullo-frequenz
force-pushed
the
feature/update-sdk
branch
from
66283a0
to
362df15
Compare
The CI job for testing the documentation website generation is failing because of error: No module named 'griffe.collections'. Updating the version of the mkdocstrings-python package fixes this issue. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
llucax
approved these changes
Aug 28, 2024
Comment on lines
+187
to
+188
| "grpc.aio", | ||
| "grpc.aio.*", |
There was a problem hiding this comment.
Just upgrading the SDK made it start complaining about this? Weird.
There was a problem hiding this comment.
Yes, I ran nox without any changes and all the checks passed.
Then I updated channels, and again all checks passed.
After updating the SDK dependency to:
diff --git a/pyproject.toml b/pyproject.toml
index 76ee55c..47227e5 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -39,7 +39,7 @@ dependencies = [
# Make sure to update the version for cross-referencing also in the
# mkdocs.yml file when changing the version here (look for the config key
# plugins.mkdocstrings.handlers.python.import)
- "frequenz-sdk == 1.0.0rc601",
+ "frequenz-sdk == 1.0.0-rc801",
"frequenz-channels >= 1.1.0, < 2.0.0",
"frequenz-client-dispatch >= 0.5.0, < 0.6.0",
]And I got the following errors in mypy:
nox > Running session mypy
nox > Creating virtual environment (virtualenv) using python in .nox/mypy
nox > python -m pip install -e '.[dev-mypy]'
nox > mypy
src/frequenz/dispatch/actor.py:10: error: Skipping analyzing "grpc.aio": module is installed, but missing library stubs or py.typed marker [import-untyped]
src/frequenz/dispatch/actor.py:10: error: Skipping analyzing "grpc": module is installed, but missing library stubs or py.typed marker [import-untyped]
src/frequenz/dispatch/_dispatcher.py:9: error: Skipping analyzing "grpc.aio": module is installed, but missing library stubs or py.typed marker [import-untyped]
src/frequenz/dispatch/_dispatcher.py:9: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
src/frequenz/dispatch/_dispatcher.py:9: error: Skipping analyzing "grpc": module is installed, but missing library stubs or py.typed marker [import-untyped]
Found 4 errors in 2 files (checked 6 source files)
nox > Command mypy failed with exit code 1
nox > Session mypy failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest frequenz-SDK 1.0.0-rc801 is required to resolve dependency conflicts for SDK apps based on that version.