Fix recurrence #71
Fix recurrence #71
Conversation
Recurrence didn't properly work as we passed in the empty list for the by-* fiedls by default which means "No valid time-unit", e.g bymonth=[] means no month at all. never. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
github-actions
bot
added
part:docs
Marenz
requested review from
llucax
and removed request for
andrew-stevenson-frequenz
| @@ -2,4 +2,4 @@ | |||
|
|
|||
| ## Summary | |||
|
|
|||
| * `frequenz-sdk` dependency has been extended to include version `1.0.0-rc1000`. | |||
| This is a hot fix for recurrence not working | |||
There was a problem hiding this comment.
Can you describe better what the issue exactly was here too? As a user I have no idea how my code was affected before this release and what should I expect from this one.
There was a problem hiding this comment.
There is really only one user and I talked to him already ;)
There was a problem hiding this comment.
You can assume that it wasn't working at all before, the chance that it was is very low.
If it was working for the user before, they must already have a detailed understanding of this problem or they couldn't have worked around it
There was a problem hiding this comment.
Well, you don't know for sure, this is a public repo. I'm sure we have plenty of external users 
But anyway, I think it is good practice to write notes that are useful, otherwise there isn't much point in writing them at all.
There was a problem hiding this comment.
Well, I see all the logs and request in the API, I know for sure :P
But.. yes, I suppose it is good practice.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Recurrence didn't properly work as we passed in the
empty list for the by-* fiedls by default
which means "No valid time-unit",
e.g bymonth=[] means no month at all. never.