Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The migration script for repo-config updates is not formatted for macOS #302

Open
camille-bouvy-frequenz opened this issue Aug 7, 2024 · 0 comments
Labels
part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working

Comments

@camille-bouvy-frequenz
Copy link

What happened?

Update repo-config to v0.10.0 following the instructions described here does not work. Reason for this is that some commands are formatted differently in macOS (e.g. sed -i needs to be followed by an empty string).

What did you expect instead?

Maybe having another script for the macOS users if that's an option

Affected version(s)

No response

Affected part(s)

Build script, CI, dependencies, etc. (part:tooling)

Extra information

No response

@camille-bouvy-frequenz camille-bouvy-frequenz added priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working labels Aug 7, 2024
@keywordlabeler keywordlabeler bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Aug 7, 2024
llucax added a commit to llucax/frequenz-repo-config-python that referenced this issue Aug 29, 2024
The labeler configuration example was using a wrong key, it should be
`all-globs-to-all-files` instead of `all-glob-to-all-file`.

Note we use `perl` instead of `sed` in the migration script because it
is more portable and we don't need to worry about the differences
between the different `sed` implementations (refs frequenz-floss#302).

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax added a commit to llucax/frequenz-repo-config-python that referenced this issue Sep 12, 2024
The labeler configuration example was using a wrong key, it should be
`all-globs-to-all-files` instead of `all-glob-to-all-file`.

Note we use `perl` instead of `sed` in the migration script because it
is more portable and we don't need to worry about the differences
between the different `sed` implementations (refs frequenz-floss#302).

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax added a commit to llucax/frequenz-repo-config-python that referenced this issue Sep 12, 2024
The labeler configuration example was using a wrong key, it should be
`all-globs-to-all-files` instead of `all-glob-to-all-file`.

Note we use `perl` instead of `sed` in the migration script because it
is more portable and we don't need to worry about the differences
between the different `sed` implementations (refs frequenz-floss#302).

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-merge-queue bot pushed a commit that referenced this issue Sep 12, 2024
The labeler configuration example was using a wrong key, it should be
`all-globs-to-all-files` instead of `all-glob-to-all-file`.

Note we use `perl` instead of `sed` in the migration script because it
is more portable and we don't need to worry about the differences
between the different `sed` implementations (refs #302).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant