-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add polling parameters to ConfigManagingActor #1082
Add polling parameters to ConfigManagingActor #1082
Conversation
The ConfigManagingActor now allows to force file polling and set the polling interval. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
Damn, cross-arch tests are consistently failing for
Super weird, I can't see ow this change could be related to this. |
This test was failing in arm64 runs, because of a large time difference. This fixes the issue. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
I fixed it, in the latest commit. Here's a successful run: https://github.com/shsms/frequenz-sdk-python/actions/runs/11201255580/job/31135960350 It is too complicated to explain how this fixes it, so I won't. |
This is not great 😟 I see in the commit with the fix you at least explain something. Can you maybe mention at least what do you think it triggers this issue, as it seems completely unrelated to the update to of the channels version? I wonder if there is something we can learn from here about expecting similar issues when upgrading other projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the changes LGTM, I would like to know more about the root cause of the new breakage, in case we bump into similar issues when upgrading to channels 1.2 in other projects, but we can merge anyways.
I actually have no idea. The commit reduces the delay by 0.1 seconds, so technically it couldn't have made up for the 0.6s lag that we were seeing in the failing test. I think it is just software emulated VM flakiness. |
That was actually a joke, I guess it wasn't obvious. :D |
No, I'm too scared of this kind of failure/flakiness, I guess my jokes detector doesn't perform well in these kind of extreme conditions :P |
The ConfigManagingActor now allows to force file polling and set the polling interval.