Remove redundant check in BatteryPool tests #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ela-kotulska-frequenz
added
the
part:tests
ela-kotulska-frequenz
requested review from
shsms
and removed request for
a team
shsms
previously approved these changes
Oct 10, 2024
ela-kotulska-frequenz
force-pushed
the
bat_pool_test
branch
from
c084cfc to
09a4ce2
Compare
This commit removes a redundant check from the BatteryPool tests. The check was deemed unnecessary as we already use a timeout when waiting for messages, which effectively proves that messages are received quickly. The removed check had recently started failing in CI environments, on arm64 architecture with Python3.11 and pytest_max. Despite efforts to reproduce the failure locally on arm64, all tests passed successfully. The CI failure appears to be caused by an 'await' hanging rather than an issue in our codebase. Removing this redundant check should resolve the intermittent CI failures without compromising test coverage or reliability. Signed-off-by: Elzbieta Kotulska <elzbieta.kotulska@frequenz.com>
ela-kotulska-frequenz
force-pushed
the
bat_pool_test
branch
from
09a4ce2 to
101fb92
Compare
shsms
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes a redundant check from the BatteryPool tests. The check was deemed unnecessary as we already use a timeout when waiting for messages, which effectively proves that messages are received quickly.
The removed check had recently started failing in CI environments, on arm64 architecture with Python3.11 and pytest_max. Despite efforts to reproduce the failure locally on arm64, all tests passed successfully.
The CI failure appears to be caused by an 'await' hanging rather than an issue in our codebase. Removing this redundant check should resolve the intermittent CI failures without compromising test coverage or reliability.