Use a sentinel in LatestValueCache to denote if the cache is empty
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because `None` is a valid value that could have been sent through a channel, so the having a `None` value might not mean that the cache is empty. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
github-actions
bot
added
part:actor
shsms
added
the
cmd:skip-release-notes
|
This is an internal fix for something that was introduced in this release cycle, so no release notes necessary. |
The previous commit has introduced the possibility for exceptions to be raised from the implementation of `latest_value` property. Properties should ideally not raise, so we replace it with the `get` method. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
daniel-zullo-frequenz
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because
Noneis a valid value that could have beensent through a channel, so the having a
Nonevalue might not alwaysmean that the cache is empty.
Closes #820