Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the last reference to darglint #877

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Remove the last reference to darglint #877

merged 1 commit into from
Feb 14, 2024

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Feb 14, 2024

This one somehow went unnoticed in #873.

@llucax llucax requested a review from a team as a code owner February 14, 2024 12:44
@llucax llucax requested a review from shsms February 14, 2024 12:44
@llucax llucax self-assigned this Feb 14, 2024
@llucax
Copy link
Contributor Author

llucax commented Feb 14, 2024

Enabling auto-merge.

@llucax llucax enabled auto-merge February 14, 2024 12:45
@github-actions github-actions bot added the part:actor Affects an actor ot the actors utilities (decorator, etc.) label Feb 14, 2024
@llucax llucax added type:enhancement New feature or enhancement visitble to users type:tech-debt Improves the project without visible changes for users labels Feb 14, 2024
@llucax llucax added this to the v1.0.0-rc5 milestone Feb 14, 2024
@daniel-zullo-frequenz daniel-zullo-frequenz added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Feb 14, 2024
@daniel-zullo-frequenz daniel-zullo-frequenz changed the title Remove the last refernce to darglint Remove the last reference to darglint Feb 14, 2024
daniel-zullo-frequenz
daniel-zullo-frequenz approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the commit message in case you'd like to fix it. LGTM
(That's why I removed the auto-merge)

@llucax llucax added this pull request to the merge queue Feb 14, 2024
@llucax llucax removed this pull request from the merge queue due to a manual request Feb 14, 2024
@llucax
Remove the last reference to darglint
a09c786 
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
@llucax
Copy link
Contributor Author

llucax commented Feb 14, 2024

Fixed, updated and re-enabled auto-merge.

@llucax llucax enabled auto-merge February 14, 2024 15:07
@llucax llucax added this pull request to the merge queue Feb 14, 2024
Merged via the queue into frequenz-floss:v1.x.x with commit 38e8604 Feb 14, 2024
14 checks passed
@llucax llucax deleted the rm-dar branch February 14, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-zullo-frequenz daniel-zullo-frequenz daniel-zullo-frequenz approved these changes

@shsms shsms Awaiting requested review from shsms shsms is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

@llucax llucax

Labels
cmd:skip-release-notes It is not necessary to update release notes for this PR part:actor Affects an actor ot the actors utilities (decorator, etc.) type:enhancement New feature or enhancement visitble to users type:tech-debt Improves the project without visible changes for users
Projects
Python SDK Roadmap
Status: Done
Milestone
v1.0.0-rc5
Development

Successfully merging this pull request may close these issues.
2 participants
@llucax @daniel-zullo-frequenz