-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux support #4
Conversation
Support for kde plasma implemented.
Implemented check_dconf for GTK based Desktop Environments. Implemented check_file to read from configuration files. Implemented cases for: - Cinnamon - Gnome - MATE - Unity - XFCE
The last commit implemented |
Co-authored-by: Corey Farwell <coreyf@rwell.org>
Co-authored-by: Corey Farwell <coreyf@rwell.org>
Is this pull request still in-progress? |
Been kinda busy but still in-process. Converting to draft. |
This should prefer the new Freedesktop standard and fall back to legacy desktop environment specific methods if that is not available. |
I will take a look at it. |
I added initial support for FreeDesktop's color-scheme key, I would appreciate some help testing this code as I don't currently have this key present in my system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to merge, already tested the new color-scheme
implementation.
I will make the required changes to macOS and Windows to accommodate the Result we return from main
now.
This should be ready to merge now 🙂 |
I got a 404 when I clicked the invitation 🤔 |
@edfloreshz What happens if you go here? https://github.com/frewsxcv/rust-dark-light/invitations |
Got it! Thanks 🙏🏼 |
Co-authored-by: Be <be.0@gmx.com>
…replaced `if let` with `match`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, all reviews have been resolved, I would suggest we test this thing out before we merge it @Be-ing
How about I rebase and clean up the Git history tomorrow and open a new pull request before merging? I'll do some testing on all the supported desktop environments too. |
Co-authored-by: Be <be.0@gmx.com>
Sounds good! Let me know if you notice something else. |
We can squash all the commits into one, edit the commit message and merge right from GitHub, we don't have to open another PR. @Be-ing I have redacted the following commit message, let me know your thoughts.
If you're okay with this commit message let me know after you're done testing so I can merge. |
I did a bit more than squashing to one big commit, see #6. |
Closing because of #6 |
This PR adds support for Linux by implementing the FreeDesktop standard
color-scheme
key.In the event this key isn't present in the system, the crate will fallback to traditional ways of figuring out if dark mode is enabled.
This PR is ready to be merged.
Fixes #1