Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed binary classification evaluation #228

Merged
merged 3 commits into from
Jul 16, 2022
Merged

fix: Fixed binary classification evaluation #228

merged 3 commits into from
Jul 16, 2022

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jul 16, 2022

This PR fixes the accuracy computation for binary classification.

@frgfm frgfm added bug Something isn't working module: trainer labels Jul 16, 2022
@frgfm frgfm added this to the 0.2.1 milestone Jul 16, 2022
@frgfm frgfm self-assigned this Jul 16, 2022
@frgfm frgfm added the critical label Jul 16, 2022
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #228 (50767b1) into main (49125c2) will decrease coverage by 0.08%.
The diff coverage is 78.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   93.51%   93.43%   -0.09%     
==========================================
  Files          56       56              
  Lines        3132     3136       +4     
==========================================
+ Hits         2929     2930       +1     
- Misses        203      206       +3     
Impacted Files Coverage Δ
holocron/trainer/classification.py 86.44% <65.00%> (-4.64%) ⬇️
holocron/trainer/core.py 89.57% <100.00%> (+0.30%) ⬆️
holocron/trainer/segmentation.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit bc0d972 into main Jul 16, 2022
@frgfm frgfm deleted the eval-fix branch July 16, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical module: trainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant