Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(mypy): silence incorrect typing warnings #375

Merged
merged 2 commits into from
Sep 11, 2024
Merged

style(mypy): silence incorrect typing warnings #375

merged 2 commits into from
Sep 11, 2024

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Sep 11, 2024

This PR silences the warnings of mypy, which are incorrect

@frgfm frgfm added the type: enhancement New feature or request label Sep 11, 2024
@frgfm frgfm self-assigned this Sep 11, 2024
@frgfm frgfm changed the title style(mypy): silenced incorrect typing warnings style(mypy): silence incorrect typing warnings Sep 11, 2024
@github-actions github-actions bot added module: optim topic: build Related to build and installation module: trainer labels Sep 11, 2024
@frgfm frgfm merged commit 84f775c into main Sep 11, 2024
29 of 30 checks passed
@frgfm frgfm deleted the mypy-fix branch September 11, 2024 17:45
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (71ba1ab) to head (e70d951).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files          62       62           
  Lines        3776     3776           
=======================================
  Hits         3540     3540           
  Misses        236      236           
Files with missing lines Coverage Δ
holocron/optim/adabelief.py 85.71% <100.00%> (ø)
holocron/optim/adamp.py 88.05% <100.00%> (ø)
holocron/optim/adan.py 88.15% <100.00%> (ø)
holocron/optim/ademamix.py 89.39% <100.00%> (ø)
holocron/optim/wrapper.py 85.60% <ø> (ø)
holocron/trainer/core.py 90.43% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: optim module: trainer topic: build Related to build and installation type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant