Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not stop preview while tweaking keyframes on timline /graph #161

Closed
adambelis opened this issue May 25, 2024 · 2 comments
Closed

Do not stop preview while tweaking keyframes on timline /graph #161

adambelis opened this issue May 25, 2024 · 2 comments
Labels
enhancement New feature or request ux
Milestone

Comments

@adambelis
Copy link

adambelis commented May 25, 2024

Curently playbec stops every time you change keyfram this is quit annoying while tweaking timing of animaitons
https://github.com/friction2d/friction/assets/50795097/68e1f92c-901f-4c62-9f18-38bfcd48f6d6

its probably performance problem but i would still prefer if i hade to wayt for recalculation then nonstop hitting space bar

Cinema_4D_SkTGJjbAAZ.mp4
@adambelis adambelis changed the title Do not stop previe while tweeking keyframes /graph Do not stop preview while tweaking keyframes on timline /graph May 25, 2024
@rodlie
Copy link
Member

rodlie commented May 25, 2024

Currently the playback will stop if you change anything, no point in looking at old cache. This was a workaround for something at some point, don't remember.

I see no reason why we can't re-cache when something change (during playback).

@rodlie rodlie added the enhancement New feature or request label May 25, 2024
@rodlie rodlie mentioned this issue May 25, 2024
4 tasks
@rodlie rodlie modified the milestones: 1.0.0, 0.9.6 May 25, 2024
@rodlie rodlie added the ux label May 26, 2024
rodlie added a commit that referenced this issue May 26, 2024
Allow modifying parameters during playback (and cache new content).

Ref: #161
@rodlie
Copy link
Member

rodlie commented May 26, 2024

Fixed in ec431c7

friction-edit-while-playback-2024-05-26_02.36.10.mp4

@rodlie rodlie closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux
Projects
None yet
Development

No branches or pull requests

2 participants