Updated the profiles to reflect categories and labeled missingness #70
Conversation
|
@peterdesmet |
| label: | ||
| type: string | ||
| value: | ||
| type: integer |
There was a problem hiding this comment.
@khusmann do I understand correctly that for an integer field, defining value in categories as something other than an integer, it would have to generate a validation error?
There was a problem hiding this comment.
My understanding is this is the point of the type-based version (moving it to the logical level). Am I correct?
Deploying datapackage with
|
| Latest commit: |
2683e92
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://425eb3eb.datapackage.pages.dev |
| Branch Preview URL: | https://categories-update-profiles.datapackage.pages.dev |
|
Thanks a lot @peterdesmet! I wanted to fix it too fast so made quite a lot of inaccuracies but now it's fixed |
| type: object | ||
| required: | ||
| - value | ||
| properties: |
There was a problem hiding this comment.
Just to be sure. Defining the properties (value, label) doesn't restrict publishers to add more properties (e.g. description), correct?
There was a problem hiding this comment.
Yes, all the object are open for custom props unless it has additionalProperties: false (in-general that was the idea of an "open" to custom props specs)
|
@khusmann a question regarding alignment with the rest of Data Package: would it be beneficial/clearer if |
|
I'm merging to fix the discrepancy between the spec ad the profile. Let's open an additional issue/discussion if needed |
This is a follow-up of frictionlessdata/datapackage#68