-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExcelControl(stringified=True) documentation could clarify interaction with schemas #1659
Comments
With a bit more research, I think I understand what it is doing (though still counter-intuitive). The So to actually get an output that is all strings you need both So using
depending on the setting for
This could probably do with a documentation update to clarify what |
…action with schema - fixes ExcelControl(stringified=True) documentation could clarify interaction with schemas frictionlessdata#1659
Overview
formats.excelControl.stringified
is documented as "Stringifies all the cell values.".However it appears that it doesn't actually do that, even in the test cases that were added as part of the PR that added the
stringified
option.e.g. in
def test_xls_parser_cast_int_to_string_1251_xlsx()
the test is:where the
"E": 1
is a number not a string.Or an even simpler reproduction:
prints:
Is this the intended behaviour and I am misunderstanding the purpose of
stringified=True
or is this a bug (which I am happy to look at fixing).To be honest, the code looks like it should convert everything to strings, but it doesn't seem to according to the unit tests (and our tests). Perhaps @roll or @shashigharti might remember from their work on the PR that created this capability?
The text was updated successfully, but these errors were encountered: