Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

127 compare header and schema #146

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

127 compare header and schema #146

wants to merge 17 commits into from

Commits on Aug 3, 2023

  1. add test skeletons for #127

    @PietrH
    PietrH committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    a0894ba View commit details
    Browse the repository at this point in the history

  2. add test skeleton for when dialect$header == NULL

    @PietrH
    PietrH committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    be496b8 View commit details
    Browse the repository at this point in the history

  3. add test for missing columns in data

    @PietrH
    PietrH committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f944e46 View commit details
    Browse the repository at this point in the history

  4. add comment

    @PietrH
    PietrH committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    7de0ada View commit details
    Browse the repository at this point in the history

  5. test for error on unexpected cols in data

    @PietrH
    PietrH committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    dddd795 View commit details
    Browse the repository at this point in the history

  6. test for missing column in schema

    @PietrH
    PietrH committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    6012169 View commit details
    Browse the repository at this point in the history

  7. add test for column order mismatch between schema and data

    @PietrH
    PietrH committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    be53886 View commit details
    Browse the repository at this point in the history

  8. test to allow case mismatch between schema and data 

    test for output class instead of no_error because no_error artificially increases test coverage, and is experimental. expect_s3_class() will fail on any error.
    @PietrH
    PietrH committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f1f5171 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Assert that column header from data and column names from schema match

    @PietrH
    PietrH committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6c9cba1 View commit details
    Browse the repository at this point in the history

  2. get column names directly from data

    @PietrH
    PietrH committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    dff14b9 View commit details
    Browse the repository at this point in the history

  3. use identical for comparing vectors

    @PietrH
    PietrH committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    c1c687c View commit details
    Browse the repository at this point in the history

  4. read header from first file

    @PietrH
    PietrH committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    4995049 View commit details
    Browse the repository at this point in the history

  5. use base to remove list elements, doesn't leave an empty element

    @PietrH
    PietrH committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5cff753 View commit details
    Browse the repository at this point in the history

  6. capitalize comments

    @PietrH
    PietrH committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    f5ce78b View commit details
    Browse the repository at this point in the history

  7. use base instead of purrr to change case, don't drop child elements

    @PietrH
    PietrH committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a401848 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. add missing space

    @PietrH
    PietrH committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    64ed260 View commit details
    Browse the repository at this point in the history

  2. use system.file() instead of file.path() for package internal fil… 

    …e references
    @PietrH
    PietrH committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    c93abcc View commit details
    Browse the repository at this point in the history