-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: custom colors and fonts #108
Comments
I would actually argue setting a color value in the |
I'd agree with @pinpox here. |
It is certainly simpler to do it that way :). Lets just do it in the config file then. |
I tried a bit to work on this, but my rust skills are limited. This works to set colors from a hex string, how would I access the values from the config that I added? If someone can give me an example I can add all the missing colors and create a PR 0f3bcdc |
Hey @pinpox, so nice that you are working on this 🤩. To access the settings you can just create a new instance of the settings object whereever you need it like this: |
Thank you, that got me to a working version. I opened a draft PR as there are still a few issues. |
Partly Fixes #108 I implemented basic color settings trying to follow the other settings. Since I havn't worked with this very much before, I'm sure there is stuff I missed or should be done differently. Please let me know what has to change, any hints very welcome. I only implemented colors for now. Not sure if font settings should be a separate PR. --------- Co-authored-by: Christian Friedow <christian@friedow.com>
Setting custom colors has been done in #141. Custom fonts is still TODO :). |
I had a short look at how this might be done, but the font paths seem to be hardcoded. I guess a third-party library would be the way to go? |
I don't think we need a third party library here. The font path is only hardcoded because we load a font which is not installed on the users system already. I think you could just try not loading a font at all if the user sets a custom font and setting another font name here: https://github.com/friedow/centerpiece/blob/main/client/src/main.rs#L277. Since the user should have installed and loaded the custom font already we should just be able to use it. |
Work in progress PR for font settings here: #143 |
I would love to be able to configure my own colors and font. I use the same font everywhere on my system and would like to have it in the laucher aswell.
The text was updated successfully, but these errors were encountered: