Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guzzle json method is deprecated #176

Closed
ghost opened this issue Oct 13, 2021 · 4 comments
Closed

Guzzle json method is deprecated #176

ghost opened this issue Oct 13, 2021 · 4 comments
Assignees
@SebSept
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Oct 13, 2021 •
edited by ghost
Loading

Describe the bug

Guzzle json method is deprecated for PSR-7, we can use

            $content = json_decode($response->getBody()->getContents());
            $version = $content->tag_name;

Fop Console Version

Fop console version 1.4.0

Prestashop Version

8.0

Php Version

Your server php version (7.4+)

Additional context

Capture d’écran de 2021-10-13 08-29-13
@ghost ghost added the bug Something isn't working label Oct 13, 2021
@ghost
Copy link
Author

ghost commented Oct 13, 2021

@SebSept

@ghost ghost mentioned this issue Oct 13, 2021
Merged
@SebSept SebSept self-assigned this Oct 13, 2021
@SebSept
Copy link
Contributor

SebSept commented Oct 13, 2021 •
edited
Loading

good catch.
I'll fix it asap

@SebSept
Copy link
Contributor

SebSept commented Oct 13, 2021

are we supposed to support PrestaShop 8 ?

@ghost
Copy link
Author

ghost commented Oct 14, 2021

Not at the moment.
It's better to note and correct when you see a problem.

SebSept added a commit that referenced this issue Oct 14, 2021
@SebSept
Merge pull request #181 from SebSept/fix_176
eafd8fe 
Version command can run on PrestaShop 8 - fix #176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebSept SebSept

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SebSept