Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpstan level 5 ... #144

Merged
merged 5 commits into from
Jul 6, 2021
Merged

phpstan level 5 ... #144

merged 5 commits into from
Jul 6, 2021

Conversation

SebSept
Copy link
Contributor

@SebSept SebSept commented Jul 1, 2021

No description provided.

@SebSept
Fix Images:GenerateAbstract : missing return statement
8cc4c88 
Signed-off-by: SebSept <sebastienmonterisi@yahoo.fr>
@SebSept SebSept added the enhancement small improvement label Jul 1, 2021
@SebSept
Fix Images:GenerateAbstract regenerateNewImages() signature
4f20bf2 
Signed-off-by: SebSept <sebastienmonterisi@yahoo.fr>
@SebSept
Fix Images:GenerateAbstract regenerateNoPictureImages() signature
7108bd1 
Signed-off-by: SebSept <sebastienmonterisi@yahoo.fr>
@SebSept
Fix Bad @var reference.
8ef1d1d 
Signed-off-by: SebSept <sebastienmonterisi@yahoo.fr>
@SebSept
not about "#^Function dump invoked with 2 parameters, 1 required\\.$#"
37923c1 
Signed-off-by: SebSept <sebastienmonterisi@yahoo.fr>
@ghost ghost self-requested a review July 2, 2021 05:57
ghost
ghost approved these changes Jul 2, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@ghost
Copy link

ghost commented Jul 2, 2021

We can close this issue #136 ?

@SebSept
Copy link
Contributor Author

SebSept commented Jul 2, 2021

not yet.
There is one error, that may be solved.

@SebSept SebSept linked an issue Jul 2, 2021 that may be closed by this pull request
PHPStan : Errors to fix #136
Closed
@SebSept SebSept marked this pull request as ready for review July 4, 2021 20:04
@SebSept
Copy link
Contributor Author

SebSept commented Jul 4, 2021

I don't know how to solve the reported error 'Call to an undefined method Symfony\Component\Console\Application::getKernel()'
So this is ready to merge.

@SebSept SebSept requested a review from a user July 4, 2021 20:08
@ghost ghost requested review from nenes25, jf-viguier and Mch0 July 5, 2021 07:57
@nenes25 nenes25 merged commit 469ad4c into friends-of-presta:dev Jul 6, 2021
@SebSept SebSept deleted the stan_again branch October 13, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nenes25 nenes25 nenes25 approved these changes

@jf-viguier jf-viguier Awaiting requested review from jf-viguier

@Mch0 Mch0 Awaiting requested review from Mch0

Assignees
No one assigned
Labels
enhancement small improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHPStan : Errors to fix
2 participants
@SebSept @nenes25