Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details on php cs fixer failure - fixes #198 #201

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Details on php cs fixer failure - fixes #198 #201

merged 1 commit into from
Oct 31, 2021

Conversation

SebSept
Copy link
Contributor

@SebSept SebSept commented Oct 30, 2021

No description provided.

@SebSept
php-cs-fixer.yml outputs a diff.
ac22b95 
easier debug.

Signed-off-by: SebSept <sebastienmonterisi@yahoo.fr>
@SebSept SebSept added the dev related to fop console development label Oct 30, 2021
@SebSept SebSept self-assigned this Oct 30, 2021
@SebSept
Copy link
Contributor Author

SebSept commented Oct 30, 2021

You can see the error on line 15, there a space that needs to be removed.
https://github.com/friends-of-presta/fop_console/runs/4056594115?check_suite_focus=true
Capture d’écran de 2021-10-30 21-41-55

@SebSept SebSept force-pushed the 198_details_on_php-cs-fixer_failure_ branch from daa342b to ac22b95 Compare October 30, 2021 19:43
@SebSept
Copy link
Contributor Author

SebSept commented Oct 30, 2021

I've forced push to remove the demo commit.

@SebSept SebSept requested review from jf-viguier, tom-combet, nenes25 and a user October 30, 2021 19:45
@SebSept SebSept linked an issue Oct 30, 2021 that may be closed by this pull request
Display more details for PHP-CS-Fixer errors #198
Closed
tom-combet
tom-combet approved these changes Oct 31, 2021
View reviewed changes
Copy link
Contributor

@tom-combet tom-combet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nenes25
nenes25 approved these changes Oct 31, 2021
View reviewed changes
Copy link
Member

@nenes25 nenes25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! 😄

@nenes25 nenes25 merged commit 955d777 into friends-of-presta:dev Oct 31, 2021
@SebSept SebSept deleted the 198_details_on_php-cs-fixer_failure_ branch May 3, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nenes25 nenes25 nenes25 approved these changes

@tom-combet tom-combet tom-combet approved these changes

@jf-viguier jf-viguier Awaiting requested review from jf-viguier

Assignees

@SebSept SebSept

Labels
dev related to fop console development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display more details for PHP-CS-Fixer errors
3 participants
@SebSept @nenes25 @tom-combet