-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronise about:version command to last Prestashop version. #250
Conversation
Hi @MeKeyCool, Thanks for your PR 😄 the fix you suggest is related with the improvements done in Prestashop 8 i guess ? As we want to keep this tool compatible with not only the lastest version of Prestashop, i think we should use a way where we can manage both v8 and other version. ping @SebSept @jf-viguier WDYT ? |
Yes, this change is related to a breaking change in Prestashop v8. 🤔 As it is only a check, I think I can make something that work for both version ... I'll try tomorrow ;) |
At the moment, we havn't decide to change the minimal support version. I have a plan to make a command that displays information about a module, I guess I'll write a custom dataprovider for the purpose. So we can use that dataprovider for the current command. |
For the moment, we can can use something more simple that will support both v8 and 1.7.5 By the way, can't we use services ? It will be easy to check if a service is defined or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment support for v8 and 1.7.5 is needed.
7b6bce8
to
f396f65
Compare
f396f65
to
772c4eb
Compare
772c4eb
to
0519f8b
Compare
@SebSept , was your change request about the type check ? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 😃👍
Little change requested but not mandatory since you check the type later.
Thanks @MeKeyCool 😎 |
Take a look at PrestaShop/PrestaShop#27632,
ModuleRepositoryInterface
as been moved