Be able to move/add in bulk clients from one group client to another

[PululuK]

Feature request

Be able to move/add in bulk clients from one group client to another

Specs

To be able to transfer customers from a Group_A group to a Group_B

⚠️ have at least two groups and at least one customer associated with one of the groups

Select groups

1 - be able to select Group_A (group from) : only groups with at least one customer
2 - be able to select Group_B (group to) : The previously selected group must not be in this list.

Select action before

Select an action once the clients of group Group_A have been transferred to group Group_B

1 - Delete Group_A group :  if we choose this option group Group_A will be deleted after transfer

This option is not displayed if Group_A is a Pretashop default group (customer, guest, unidentified)

2 - Remove customers in Group_A group : if we choose this option customers will be removed from the Group_A

⚠️ In both cases (1) and (2), if Group_A was the customer's default group, Group_B became its default group.

3 - Just add to new group : if we choose this option users of group Group_A will be added to group Group_B
4 - Cancel current action : Command exit :)

POC

🎥 Click to see screen record

[PululuK]

ping @SebSept @akiletour @jf-viguier

Ready for review :)

[SebSept]

Thanks for this PR.
Please be patient, before it could be merged, I have lot of work at the moment and I think I'm not the only one in that situation.

[SebSept]

Good job 👍🏼
I added a few remarks.
I'll test the code later.

[SebSept]

Almost done !
Sorry to bother you, it will be nice if you could fix this problems reported by phpstan (level 2 only) :

 ------ ----------------------------------------------------------------------- 
  Line   CustomersGroups.php                                                    
 ------ ----------------------------------------------------------------------- 
  120    Method FOP\Console\Commands\Customers\CustomersGroups::execute()       
         should return int|null but return statement is missing.                
  146    PHPDoc tag @return with type null is incompatible with native type     
         void.                                                                  
  146    PHPDoc tag @throws with type FOP\Console\Commands\Customers\Exception  
         is not subtype of Throwable                                            
  259    PHPDoc tag @param references unknown parameter: $type                  
  357    PHPDoc tag @return with type FOP\Console\Commands\Customers\in is      
         incompatible with native type int.                                     
  357    Return typehint of method                                              
         FOP\Console\Commands\Customers\CustomersGroups::getDefautlLang() has   
         invalid type FOP\Console\Commands\Customers\in.                        
  380    PHPDoc tag @throws with type                                           
         FOP\Console\Commands\Customers\UnexpectedValueException is not         
         subtype of Throwable                                                   
 ------ ----------------------------------------------------------------------- 

 [ERROR] Found 7 errors   

Phpstan will be integrated as a github action and available as a local tool.
So to avoid fixing this warnings, it could be good to fix it before merging.
(for the moment, you can try with https://github.com/PrestaShop/php-dev-tools which is already a dependency of this module, but that's no required, you can use my report above.)

[SebSept]

Just for info, do you plan to fix this phpstan warnings ?

[PululuK]

Just for info, do you plan to fix this phpstan warnings ?

Hi @SebSept
I'm sorry. Yes I will fix it.
Thanks

[PululuK]

Hi @SebSept
Can you run phpstan tests again please ?
Thanks

[SebSept]

I though this constants were available with this symfony version. But they are not.
It's only for later versions.

It's nice that you added it !
(We'll move them to the base command later.)

[PululuK]

Yes !
I noticed that in our version they don't exist, that's why I added them in my class. But I think for the sake of reusability we should put them in the Command class.

[SebSept]

phpstan & php-cs-fixer are happy, Nice :)
I'll run a few tests tomorrow before merging.

Thanks !

[SebSept]

The error message needs to be more explicit. Why did the command aborted ?
So does the help message.

[SebSept]

Also I think that the word "move" is not appropriate.
Because in fact this allows us to add customers from a group to another group.
And, as an option, remove the customer from the source group (so that's a move) but if I choose, "Just add to new group", that's not really a move.

[SebSept]

@PululuK Can you just add a more explicit message ?
then I'll merge the command if other reviewers are ok.

(I wish I could add the message but I'm not really sure of the error)

[SebSept]

To me, the non explicit error message is confusing.
The user deserve to know what was wrong.
I suppose it is related to the fact that there is a need to have users in different groups as mentioned in the PR explanation. But I'm not sure.
Can someone confirm this and write a correct error message ?

I also mention the fact that the command result can be something different than a 'move', user can be added to a group without being removed from the source one.
Because of the current lack of time of reviewer I suggest to merge with this wrong definition.
Unless someone fix it.

[SebSept]

Just a last effort to seal your work @PululuK ? 🙏🏼

[jf-viguier]

If we follow naming convention, the command should e named fop:customer:transfert ? or splitted in fop:customer:move and fop:customer:copy ?

[SebSept]

the "group" concept is important ...
fop:customer:group-change ?

[PululuK]

the "group" concept is important ...
fop:customer:group-change ?

Hello I'm back !
Seems good to me ! Or fop:customer:group-manager wdyf @SebSept @jf-viguier ?

[SebSept]

Personne pour finaliser ça ?

[Mch0]

fop:customer:group-change it's ok for me

[Mch0]

Just update name of Command and it's ok

[SebSept]

Finally I think my proposal (fop:customer:group-change was not good, because the command can leave customer into a group, so they did not changed their group.)

fop:customer:group-manage looks like the best choice.

If anyone has something against that choice, it's time to speak, now or never 😆
I'll make the change and merge on Friday..

[SebSept]

thanks @PululuK (and sorry for the delay).