Merge pull request #80 from mazarini/master

Fix unused variable for tag "embed"
friendsoftwig · Oct 7, 2019 · e404c43 · e404c43
2 parents 16ea015 + ec57526
commit e404c43
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/Rule/UnusedVariable.php b/src/Rule/UnusedVariable.php
@@ -39,6 +39,7 @@ public function check(\Twig_TokenStream $tokens)
                 $blockType = $tokens->look(2)->getValue();
 
                 switch ($blockType) {
+                    case 'embed':
                     case 'include':
                         if ('with' === $tokens->look(6)->getValue()) {
                             $this->skip($tokens, 8);

diff --git a/tests/FunctionalTest.php b/tests/FunctionalTest.php
@@ -248,6 +248,10 @@ public function getData()
             ['{% set bar %}1{% endset %}{% include "foo.html.twig" with {bar: foo} only %}', 'Unused variable "bar".'],
             ['{% include "foo.html.twig" %}', null],
 
+            // Check unused for embed
+            ['{% set foo %}1{% endset %}{% embed "foo.html.twig" with {foo: foo} only %}{% endembed %}', null],
+            ['{% set bar %}1{% endset %}{% embed "foo.html.twig" with {bar: foo} only %}{% endembed %}', 'Unused variable "bar".'],
+
             // Check regression of https://github.com/friendsoftwig/twigcs/issues/62
             ['{%~ if foo ~%}', null],
             ['{%~ if foo ~%}', null],