Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add excluded directories #81

Merged
merged 2 commits into from
Oct 8, 2019
Merged

add excluded directories #81

merged 2 commits into from
Oct 8, 2019

Conversation

oallain
Copy link
Contributor

@oallain oallain commented Oct 7, 2019

Fixes #74

We can now optionally exclude :

No exclusion :

vendor/bin/twigcs templates/

One exclusion

vendor/bin/twigcs templates/ --exclude dir1

or multiples exclude like :

vendor/bin/twigcs templates/ --exclude dir1 --exclude dir2

@truls1502 truls1502 mentioned this pull request Oct 7, 2019
Merged
11 tasks
Ciloe
Ciloe requested changes Oct 8, 2019
View reviewed changes
Copy link
Collaborator

@Ciloe Ciloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests ? Thanks !

@OwlyCode
Copy link
Collaborator

OwlyCode commented Oct 8, 2019

We do not have tests for the command at the moment. @oallain will you need some help on that?

OwlyCode
OwlyCode approved these changes Oct 8, 2019
View reviewed changes
Copy link
Collaborator

@OwlyCode OwlyCode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@OwlyCode OwlyCode merged commit 46abeb8 into friendsoftwig:master Oct 8, 2019
@oallain
Copy link
Contributor Author

oallain commented Oct 8, 2019

Wow merged too fast @OwlyCode 😍

@Ciloe job done 😄

@oallain oallain deleted the feature-excluded-directories branch October 9, 2019 07:54
@oallain oallain mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ciloe Ciloe Ciloe requested changes

@OwlyCode OwlyCode OwlyCode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New optional parameter: excluded directories
3 participants
@oallain @OwlyCode @Ciloe