-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ignore reason #103
Allow ignore reason #103
Conversation
|
Thanks, I ran In the end it failed for me with:
When testing with 1.49.0. Not sure if that is the same indexmap issue, I guess different MSRV issue? |
I've updated master with locks on problematic crates. You can merge in that branch and tests should pass now. So I also found out that in the meantime Overall, supporting older version of rust tend to be pain in the ***. But what can we do? |
It is sufficient to declare the type as the `kw::ignore` case does.
Since Rust 1.61.0 `cargo test` has included the reason string in the output. The new syntax is optional, so `inconclusive` is still accepted, a reason may be given inside optional brackets `inconclusive["some reason"]`. Parentheses are not used to avoid ambiguity with the output/result. A custom `impl Debug` is used to avoid injecting an unsightly `inconclusivewithreason_litstr_token` into the test name by default. Fixes: frondeus#102
Thanks, I've rebased and |
Will try to release it today or tomorrow |
Awesome, thanks! |
Allow users to specify a reason why a test is
inconclusive
/ignored
and translate into#[ignore = "Reason"]
. This will be picked up bycargo test
from 1.61.0 onward and displayed in the output. e.g.Results in:
Fixes #102.