Dev 10: add lookpin page #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaann
requested changes
Nov 7, 2024
| .input-area::placeholder { | ||
| text-align: left; /* Центрирует текст placeholder */ | ||
| color: #888; /* Цвет текста для placeholder */ | ||
| } |
There was a problem hiding this comment.
Перевод строки в конце файла
|
|
||
| .input-area::placeholder { | ||
| text-align: left; /* Центрирует текст placeholder */ | ||
| color: #888; /* Цвет текста для placeholder */ |
| resize: none; | ||
| padding: 8px; | ||
| font-size: 16px; | ||
| border: 1px solid #ccc; |
public/components/input/input.js
Outdated
Comment on lines
35
to
41
|
|
||
| const parent = this.Parent; | ||
| if (parent) { | ||
| parent.innerHTML += renderedTemplate; | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Смущает, что тут пропала вставка инпута в родитель
public/constants/config.js
Outdated
Comment on lines
135
to
145
|
|
||
| // text_area: | ||
| // { | ||
| // icon: './assets/icons/pinset-logo.svg', | ||
| // placeHolder: 'Еуые', | ||
| // maxLength: 250, | ||
| // fontSize: '10px', | ||
| // minHeight: '100px', | ||
| // maxHeight: '200px', | ||
| // autoExpand: true, | ||
| // } |
There was a problem hiding this comment.
Закомменченные строчки не оставляем в коде + нет перевода строки в конце файла
public/pages/addPin/lookPin.css
Outdated
| gap: 0.5rem; | ||
| background-color: var(--project-primary-white); | ||
| border-radius: 5%; | ||
| box-shadow: 0px 0px 10px rgba(0, 0, 0, 0.5); |
Gallaann
approved these changes
Nov 17, 2024
public/pages/editPin/editPin.css
Outdated
Comment on lines
113
to
124
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Втф, что за пустые поля просто
Comment on lines
+25
to
+28
| {{!-- <div class="editpin__pinboard"> | ||
| <div class="editpin__pinboard-text">Выберите доску</div> | ||
| {{{BoardsList}}} | ||
| </div> --}} |
There was a problem hiding this comment.
Удалить, если не планируется использовать, либо добавить TODO на раскоменчивание, когда
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.