Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use urljoin to create thumbnail string #550

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Use urljoin to create thumbnail string #550

merged 1 commit into from
Mar 6, 2022

Conversation

fronzbot
Copy link
Owner

@fronzbot fronzbot commented Mar 6, 2022

Description:

Uses urljoin function from requests lib to always parse thumbnails correctly.

Note: my system doesn't have the problems in the linked issue, so I cannot be certain it fixed the problem

Related issue (if applicable): home-assistant/core#67481

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #550 (519bcec) into dev (0a03836) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #550      +/-   ##
==========================================
+ Coverage   86.23%   86.25%   +0.01%     
==========================================
  Files           8        8              
  Lines        1061     1062       +1     
==========================================
+ Hits          915      916       +1     
  Misses        146      146              
Flag Coverage Δ
unittests 86.25% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
blinkpy/camera.py 84.49% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a03836...519bcec. Read the comment docs.

@fronzbot fronzbot merged commit dc492ed into dev Mar 6, 2022
@fronzbot fronzbot deleted the fix-broken-thumb branch March 6, 2022 00:06
@fronzbot fronzbot mentioned this pull request Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant