Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doorbell mapping #599

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Fix doorbell mapping #599

merged 4 commits into from
Jul 6, 2022

Conversation

uvjim
Copy link
Contributor

@uvjim uvjim commented Jul 5, 2022

Apologies. I missed this when submitting the last PR but had it locally for some reason. Without the change the device seems to work but gets identified as a mini and then incorrect end points are used.

Description:

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Apologies.  I missed this when submitting the last PR but had it locally for some reason.  Without the change the device seems to work but gets identified as a mini and then incorrect end points are used.
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #599 (3dd7527) into dev (33fcf7a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #599   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files           8        8           
  Lines        1064     1064           
=======================================
  Hits          924      924           
  Misses        140      140           
Flag Coverage Δ
unittests 86.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
blinkpy/sync_module.py 93.91% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33fcf7a...3dd7527. Read the comment docs.

Not sure how I missed this one...
@fronzbot
Copy link
Owner

fronzbot commented Jul 6, 2022

If you fix the test_sync_functions.py file, the tests should pass and I can merge. Specifically this line:

{"name": "fake", "id": 12, "type": "lotus"},

Should replace lotus with doorbell and you should be good to go

@fronzbot fronzbot changed the title Fix up missing item from last PR Fix doorbell mapping Jul 6, 2022
@fronzbot fronzbot merged commit bd68fc0 into fronzbot:dev Jul 6, 2022
@fronzbot fronzbot mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants