Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete and download functions #745

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Aug 16, 2023

Description:

Add the Delete and Download functions for blinksync app.

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #745 (df6f510) into dev (9fa0b2e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #745   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files           8        8           
  Lines        1394     1424   +30     
=======================================
+ Hits         1389     1419   +30     
  Misses          5        5           
Flag Coverage Δ
unittests 99.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
blinkpy/helpers/util.py 100.00% <100.00%> (ø)
blinkpy/sync_module.py 100.00% <100.00%> (ø)

@mkmer
Copy link
Contributor Author

mkmer commented Aug 16, 2023

I keep having these problems - tox passes locally, then it fails tests here. It appears the local tox doesn't run black... and I keep forgetting to do it :(

@mkmer
Copy link
Contributor Author

mkmer commented Aug 16, 2023

With this piece in place, we should be clear to release to pypi and I'll put in a PR to use it :)

@fronzbot
Copy link
Owner

I keep having these problems - tox passes locally, then it fails tests here. It appears the local tox doesn't run black... and I keep forgetting to do it :(

Yeah I need to fix the linting tests- not sure why I never added it to tox to begin with

@fronzbot fronzbot merged commit 4083815 into fronzbot:dev Aug 17, 2023
@fronzbot fronzbot deleted the add-delete-and-download-functions branch August 17, 2023 02:44
@fronzbot fronzbot mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants