Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for none and empty dict in update #800

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Nov 3, 2023

Description:

the bool() operator tests for None as well as empty dict - addressing the error but not the root cause of home-assistant/core#103312

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #800 (4beb976) into dev (128854d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #800   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files           8        8           
  Lines        1447     1447           
=======================================
  Hits         1442     1442           
  Misses          5        5           
Flag Coverage Δ
unittests 99.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
blinkpy/camera.py 98.43% <100.00%> (ø)

@mkmer
Copy link
Contributor Author

mkmer commented Nov 4, 2023

Hoping to get this one in and released - I think there is a startup problem causing the AttributeError in HA and if we address it here it will keep running in HA, then I can try to figure out why it's happening.
Unfortunately I can't make it happen with my home configuration, so it's going to take a bit of trial/error with the folks on HA.

@fronzbot
Copy link
Owner

fronzbot commented Nov 5, 2023

Oh dang, sorry! I saw this is thought it was a home assistant pull request 🤦‍♂️

@fronzbot fronzbot merged commit fb7f003 into fronzbot:dev Nov 5, 2023
8 checks passed
@mkmer
Copy link
Contributor Author

mkmer commented Nov 5, 2023

No problem! I was really hoping we nailed this on the first try :) At least it was "easy".
Turns out not having a sync module on your account is the "root" cause. I'll try to get some tests in for this config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants