-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battery level #837
Battery level #837
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #837 +/- ##
==========================================
- Coverage 99.86% 99.86% -0.01%
==========================================
Files 8 8
Lines 1458 1457 -1
==========================================
- Hits 1456 1455 -1
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Do we really still need py38? |
No we do not need py38. If something is failing as a result, I'm 100% ok with deprecating 3.8 support |
It's ok - I was using |
At some point we will need to do a release to fix the HA wifi sensor issue. |
Yeah saw that. Let's give it till the weekend and I'll make a release after that (feel free to ping me if you don't see anything) |
Description:
Change name of
battery_voltage
tobattery_level
Update camera tests and utilize constant for
CONFIG
Related issue (if applicable): fixes #
Checklist:
tox
run successfully PR cannot be meged unless tests pass