Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch ContentTypeError in 2FA #843

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 4, 2024

Description:

Appears sometimes non JSON is returned in 2FA and not caught.
home-assistant/core#107143
This does not address the root problem - text instead of JSON response.

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be merged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@mkmer mkmer changed the title Catch content_type error in 2FA Catch contentTypeError in 2FA Jan 4, 2024
@mkmer mkmer changed the title Catch contentTypeError in 2FA Catch ContentTypeError in 2FA Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (864de67) 99.86% compared to head (64af647) 99.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #843   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           8        8           
  Lines        1460     1460           
=======================================
  Hits         1458     1458           
  Misses          2        2           
Flag Coverage Δ
unittests 99.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot fronzbot merged commit 3912eef into fronzbot:dev Jan 4, 2024
8 checks passed
@fronzbot fronzbot deleted the content-type-error branch January 4, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants