-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for logging #846
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #846 +/- ##
==========================================
+ Coverage 99.72% 99.86% +0.13%
==========================================
Files 8 8
Lines 1467 1467
==========================================
+ Hits 1463 1465 +2
+ Misses 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I don't know why this is failing on git but passing locally - I guess it can wait to figure it out as it's only the test. |
Maybe something specific to 3.11+? What version do you run locally? |
I think this modified test is still "good" - all we are really looking for are the 3 logged entries, don't really care if other stuff is in there. |
Sure hope the 30 second update change isn't what's killing the server! |
Description:
Add the tests for the new logging code from PR#845
Related issue (if applicable): fixes #
Checklist:
tox
run successfully PR cannot be meged unless tests pass