Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for logging #846

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Add tests for logging #846

merged 6 commits into from
Jan 5, 2024

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 5, 2024

Description:

Add the tests for the new logging code from PR#845

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0309e7b) 99.72% compared to head (f3a59fc) 99.86%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #846      +/-   ##
==========================================
+ Coverage   99.72%   99.86%   +0.13%     
==========================================
  Files           8        8              
  Lines        1467     1467              
==========================================
+ Hits         1463     1465       +2     
+ Misses          4        2       -2     
Flag Coverage Δ
unittests 99.86% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkmer mkmer closed this Jan 5, 2024
@mkmer mkmer reopened this Jan 5, 2024
@mkmer
Copy link
Contributor Author

mkmer commented Jan 5, 2024

I don't know why this is failing on git but passing locally - I guess it can wait to figure it out as it's only the test.

@fronzbot
Copy link
Owner

fronzbot commented Jan 5, 2024

Maybe something specific to 3.11+? What version do you run locally?

@mkmer
Copy link
Contributor Author

mkmer commented Jan 5, 2024

Maybe something specific to 3.11+? What version do you run locally?

tox -e py311 as well as just a stright ol' tox
Then I forget to tox -e lint and ...
It should match best I can tell. Sometimes this simple stuff just drives me nuts! Probably really just showing my lack of "true" 100% understanding.

I think this modified test is still "good" - all we are really looking for are the 3 logged entries, don't really care if other stuff is in there.

@fronzbot fronzbot merged commit b5aca74 into fronzbot:dev Jan 5, 2024
8 checks passed
@mkmer mkmer deleted the add-tests branch January 5, 2024 21:47
@mkmer
Copy link
Contributor Author

mkmer commented Jan 5, 2024

Sure hope the 30 second update change isn't what's killing the server!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants