Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for none type in command function #892

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Mar 6, 2024

Description:

Add test for None type when aiohttp returns None type addressing

Related issue (if applicable): fixes #891

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (0ec0346) to head (d704a01).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #892   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files           8        8           
  Lines        1486     1487    +1     
=======================================
+ Hits         1483     1484    +1     
  Misses          3        3           
Flag Coverage Δ
unittests 99.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot fronzbot merged commit 5a61a53 into fronzbot:dev Mar 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exception in API in case of network issue, no retries
2 participants